Updated %d to %@ when formatting the bookmark ID #3
Conversation
…s resulting in erroneous values.
|
You are absolutely right about the Regarding the NSInteger issue: using %d is in fact not working if you compile for a 64bit environment. However, Can you change that so that I can merge your pull request? |
|
I'll have to do some more testing, because switching to %ld does not have any improvement for me. As a bit of background, I'm pulling down the bookmarks and storing them in Core Data - the bookmark ID is being stored in an "Integer 64" attribute type. The format is only coming out badly when it's been through Core Data so it might be getting mangled slightly as I move it in and out. I'll do some more on it this evening if that's okay. Cheers, Maurice |
…4 bits on a 64-bit build.
|
I think part of the problem is on my end with putting the NSInteger into and out of a Core Data store. I've updated my commits as you suggested and I'll figure out my own problem at a later stage :-) Cheers, Maurice |
|
@matthiasplappert - is everything okay with the updated pull request |
Update %d to %ld when formatting the bookmark ID. Update to latest JSONKit commit.
I found that when using %d the wrong value was being output. I noted from documentation that on a 64-bit build the NSInteger would be 64 bits in size, whereas for a 32-bit build NSInteger is just 32 bits in size.
Using %@ to "print" the NSInteger seemed to work fine - it actually gave me a representation that matched the values on instapaper.com. Can you try this out and see if it works for you?
I also fixed the calls to bookmark.hash as I suspect that should have been bookmark.hashString.
Cheers,
Maurice